Throw exception when worker cannot handle submission #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gogo4ds
requested changes
Dec 5, 2023
OJS.Workers.SubmissionProcessors/ExecutionTypeFilters/SubmissionFilteringServiceBase.cs
Outdated
Show resolved
Hide resolved
gogo4ds
requested changes
Dec 11, 2023
OJS.Workers.SubmissionProcessors/ExecutionTypeFilters/SubmissionFilteringServiceBase.cs
Outdated
Show resolved
Hide resolved
gogo4ds
requested changes
Dec 14, 2023
gogo4ds
approved these changes
Dec 14, 2023
gogo4ds
deleted the
throw-exception-when-worker-cannot-handle-submission
branch
MTsatsarov
added a commit
that referenced
this pull request
Jan 24, 2024
* Work in progress * Get the key and password for health check from app settings * Set the worker endpoint to submission * Fix appveyor errors * Fix app veyor errors * Fix build errors * Add none type * Rename worker type * add setting * Remove default worker type from web project * Add collection of worker types for queue * Add logging when submission cannot be processed. * Add logging when worker response is not healthy or exception occurs in the request. * Fix logger not added * Add log for remote worker url * Fix mistake * Throw exception when worker cannot handle submission (#172) * Throw exception when worker cannot handle submission * Return worker state when checking if submission can be processed * Remove nullable check * remove nullable submission * Fix nullable worker * Fixed logic for checking worker state --------- Co-authored-by: Georgi Georgiev <[email protected]> * Fixed bool check * Removed Compiler Comment and added extension for getting all ex messages * Improved message * Remove unnecesary ProcessingComment * Fixed build error * Add NodeJs v20 strategies (#171) * Add failures count for SFP * Add multiple error methods * Remove new strategies * Fix build errors --------- Co-authored-by: Georgi Georgiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to SoftUni-Internal/OpenJudgeSystem#949