SetCommand() messes up with UI controls IsEnabled property

[TimofeyBurak]

Description

SetCommand() extension methods manipulate with Enabled/IsEnabled properties of UI elements (whenever possible), which makes it impossible to. properly control Enabled state (with bindings, for. example)

Steps to Reproduce

1. Set command to a button (button.SetCommand(ViewModel.TestCommand))
2. Add binding to enabled property (this.Bind(() => ViewModel.IsEnabled, () => button.Enabled) where ViewModel.IsEnabled == false)

Expected Behavior

Button should be disabled

Actual Behavior

Button could still be enabled

Possible Fix

SetCommand should not manipulate Enabled state of the UI elements by default. Maybe it could be an additional feature, possibility to bind to ICommand.CanExecute()

Basic Information

• Version with issue: 4f060ee
• Affected Platforms: iOS, Android

[wcoder]

Currently, bindings handled this behavior via ICommand.CanExecute() for these controls:

• iOS
  • UIControl

    XToolkit.WhiteLabel/Softeq.XToolkit.Bindings.iOS/AppleBindingFactory.cs

    Lines 97 to 106 in 7c0e75a

    	public override void HandleCommandCanExecute<T>(
    	object element,
    	ICommand command,
    	Binding<T, T> commandParameterBinding)
    	{
    	if (element is UIControl control)
    	{
    	HandleControlEnabled(control, command, commandParameterBinding);
    	}
    	}

• Android
  • any View

    XToolkit.WhiteLabel/Softeq.XToolkit.Bindings.Droid/DroidBindingFactory.cs

    Lines 144 to 153 in 7c0e75a

    	public override void HandleCommandCanExecute<T>(
    	object element,
    	ICommand command,
    	Binding<T, T> commandParameterBinding)
    	{
    	if (element is View view)
    	{
    	HandleViewEnabled(view, command, commandParameterBinding);
    	}
    	}

We are restricted by views hierarchy on iOS and should add separate behaviors for views.