Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullability for Bindings primitives #473

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Enable nullability for Bindings primitives #473

merged 1 commit into from
Feb 23, 2022

Conversation

wcoder
Copy link
Member

@wcoder wcoder commented Feb 2, 2022 •
edited
Loading

Description

Enable nullability for:

  • BindingGeneric
  • AppleBinding
  • DroidBinding
  • BindingExtesnions
  • BaseBindingFactory
  • AppleBindingFactory
  • DroidBindingFactory

Added more docs.

Issues Resolved

API Changes

None

Platforms Affected

  • Core (all platforms)
  • iOS
  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

PR Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code styles
  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@github-actions github-actions bot added c/bindings Related to Bindings component. p/Android Related to Android platform. p/iOS Related to iOS platform. labels Feb 2, 2022
@wcoder wcoder added this to the vNext milestone Feb 23, 2022
@wcoder wcoder merged commit 26baec3 into master Feb 23, 2022
@wcoder wcoder deleted the feature/enable-nullability-for-bindinggeneric branch February 23, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimpylsky vadimpylsky vadimpylsky approved these changes

@TimofeyBurak TimofeyBurak Awaiting requested review from TimofeyBurak

@nkrisko nkrisko Awaiting requested review from nkrisko

Assignees
No one assigned
Labels
c/bindings Related to Bindings component. p/Android Related to Android platform. p/iOS Related to iOS platform.
Projects
None yet
Milestone
v2 beta 10
Development

Successfully merging this pull request may close these issues.

BindingGeneric: Double converter wrapping when used IConverter
2 participants
@wcoder @vadimpylsky