Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParallelProverService: Add integration tests. #1175

Merged
merged 11 commits into from
Nov 28, 2023
Merged

Conversation

bkolad
Copy link
Member

@bkolad bkolad commented Nov 23, 2023

Description

This PR includes the following changes:

  1. Adds handling for the ProofProcessingStatus::Busy status
  2. Extends the MockZkvm with functionality to simulate a slow proving process, effectively halting the current worker thread.
  3. Adds unit tests for the ParallelProverService.

See #1185 regarding future work.

Linked Issues

Testing

Adds new integration tests for the. ParallelProverService.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #1175 (d45392b) into nightly (1307350) will increase coverage by 1.4%.
Report is 1 commits behind head on nightly.
The diff coverage is 97.1%.

Additional details and impacted files
Files Coverage Δ
adapters/mock-da/src/types/mod.rs 80.6% <100.0%> (+7.5%) ⬆️
full-node/db/sov-db/src/schema/tables.rs 86.4% <ø> (ø)
full-node/db/sov-schema-db/src/lib.rs 92.2% <100.0%> (-0.5%) ⬇️
...sov-prover-storage-manager/src/snapshot_manager.rs 100.0% <100.0%> (ø)
full-node/sov-stf-runner/src/prover_service/mod.rs 100.0% <100.0%> (+100.0%) ⬆️
.../sov-stf-runner/src/prover_service/parallel/mod.rs 95.4% <100.0%> (+1.5%) ⬆️
rollup-interface/src/state_machine/da.rs 84.7% <ø> (ø)
adapters/avail/src/spec/hash.rs 0.0% <0.0%> (ø)
adapters/mock-zkvm/src/lib.rs 77.3% <95.8%> (+5.6%) ⬆️
full-node/sov-stf-runner/src/runner.rs 78.9% <71.4%> (-0.3%) ⬇️
... and 4 more

... and 1 file with indirect coverage changes

@bkolad bkolad force-pushed the blaze/prover_busy_status branch 2 times, most recently from 6e95e16 to 5466367 Compare November 27, 2023 20:33
@bkolad bkolad force-pushed the blaze/prover_busy_status branch from 5466367 to e386346 Compare November 27, 2023 20:35
@bkolad bkolad changed the title WIP: ProverService busy status ParallelProverService: Integration tests. Nov 28, 2023
@bkolad bkolad marked this pull request as ready for review November 28, 2023 10:42
@bkolad bkolad requested a review from citizen-stig November 28, 2023 10:42
@bkolad bkolad changed the title ParallelProverService: Integration tests. ParallelProverService: Add integration tests. Nov 28, 2023
@bkolad bkolad enabled auto-merge November 28, 2023 11:42
@bkolad bkolad added this pull request to the merge queue Nov 28, 2023
Merged via the queue into nightly with commit 6aaf68e Nov 28, 2023
15 checks passed
@bkolad bkolad deleted the blaze/prover_busy_status branch November 28, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants