Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile errors #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compile errors #1

wants to merge 2 commits into from

Conversation

serge-v
Copy link

@serge-v serge-v commented Jun 19, 2015

Fix compile errors on clang-602.0.53, target: x86_64-apple-darwin14.3.0.

@wez
Copy link
Contributor

wez commented Jun 19, 2015

Thanks! FWIW, https://bitbucket.org/wez/gimli is a slightly more up to date version of gimli; would you mind checking that out and see if that would benefit from these changes?

@serge-v
Copy link
Author

serge-v commented Jun 19, 2015

thanks. It compiles without my fixes.
However for linking I was needed to add -Wl flag for CORONER_LDFLAGS for
darwin.

diff -r e9f4b852359e configure.ac
--- a/configure.ac Mon Nov 25 11:39:56 2013 -0800
+++ b/configure.ac Fri Jun 19 16:11:32 2015 -0400
@@ -29,7 +29,7 @@
case $host in
darwin)
LDFLAGS="-lpthread"

  • CORONER_LDFLAGS="-framework Security -framework CoreFoundation
    -sectcreate __TEXT __info_plist glider.plist -export_dynamic"
  • CORONER_LDFLAGS="-framework Security -framework CoreFoundation
    -sectcreate __TEXT __info_plist glider.plist -Wl,-export_dynamic"
    SHLIB_SUFFIX=".dylib"
    RLDPATH="-R"
    DARWIN_DSYMUTIL="dsymutil -o .libs/wedgie.dSYM .libs/wedgie ; dsymutil
    -o .libs/libgimli.0.dylib.dSYM .libs/libgimli.0.dylib"

On 19 June 2015 at 15:23, Wez Furlong [email protected] wrote:

Thanks! FWIW, https://bitbucket.org/wez/gimli is a slightly more up to
date version of gimli; would you mind checking that out and see if that
would benefit from these changes?


Reply to this email directly or view it on GitHub
#1 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants