Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WE-311: Decide some of our success metrics (performance, script size, build time, etc) #638

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WE-311: Decide some of our success metrics (performance, script size, build time, etc) #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/lighthouse.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,5 @@ jobs:
urls: |
${{ steps.netlify.outputs.url }}
${{ steps.netlify.outputs.url }}/momentum/
# TODO ERY: We will need to add this back in the future, but we need to deliberate on what we find an acceptable lighthouse budget to be
# budgetPath: ./lighthouse-budget.json
budgetPath: ./lighthouse-budget.json
uploadArtifacts: true
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,7 @@ yarn-error.log*
.env

# Auto generated images
public/content
public/content

# Netlify
/.netlify/
8 changes: 4 additions & 4 deletions lighthouse-budget.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,23 @@
},
{
"metric": "first-meaningful-paint",
"budget": 2000
"budget": 5000
}
],
"resourceSizes": [
{
"resourceType": "script",
"budget": 150
"budget": 500
},
{
"resourceType": "total",
"budget": 500
"budget": 1000
}
],
"resourceCounts": [
{
"resourceType": "third-party",
"budget": 100
"budget": 200
}
]
}
Expand Down