Improve chat api toLegacy conversion #3625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
md-5
reviewed
Apr 13, 2024
| @@ -665,7 +665,10 @@ void toLegacyText(StringBuilder builder) | |||
|
|
|||
| void addFormat(StringBuilder builder) | |||
| { | |||
| builder.append( getColor() ); | |||
| if ( style.hasColor() || parent != null ) | |||
There was a problem hiding this comment.
Otherwise a constellation like {"extra":[{"text":"b","color":"red"},{"text":"c"}], "text":"a", "color":"blue"} would show the c in red instead of blue. Similar with arguments of translatables.
Unfortunaly this introduces another bug in conversion of BaseComponent array.
In new commit I added overhaul of toLegacy conversion, making it context-aware.
There was a problem hiding this comment.
Another test added for this in dc7fecd
Janmm14
force-pushed
the
keep-chatcolor-unset-in-legacy
branch
from
b2fe975 to
0bbe3e6
Compare
Janmm14
changed the title
|
Please do another review. |
… converting to legacy. In Tests: - add bunch of tests including a failing test - change expected results as unneccessary white color codes got less Co-authored-by: bob7l <[email protected]>
Janmm14
force-pushed
the
keep-chatcolor-unset-in-legacy
branch
from
dc7fecd to
5b1e75c
Compare
Janmm14
changed the title
The target is to output less redundant legacy codes, this has been achieved by using context-aware toLegacy conversion which keeps track of the current end-of-string style. Fixes behaviour change introduced in f4144eb8c2e83f43f41b24b4ea8b03b0f4c9c44e of array toLegacy conversion where the next array element would no longer reset to white color.
Janmm14
changed the title
Janmm14
force-pushed
the
keep-chatcolor-unset-in-legacy
branch
from
5b1e75c to
32dfedc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the suggested change in #3623 and improves test case code and changes the test cases affected by this change of removing unneccessary color codes in legacy output.
Additionally it improves all the componenets toString methods by not showing null methods, integrating style toString and using shorter names.moved to separate PRThis PR has a slight unwanted side effect when converting uncolored translatable components with styled parameters to legacy - in these cases the style of the parameter will stay after the styled parameter ends.Should we fix that with special casing in transable component somehow and what would be the best way of doing so?This PR overhauls toLegacy conversion with context-aware algorithm which only adds formatting codes if needed in most cases.