Merge pull request #6 from StudyTube/task/stylelint-check

Add stylelint check to the pre-commit hook

hooks/pre-commit.sh

@@ -5,30 +5,53 @@ set -e    # exit on any error
 GREEN='\033[0;32m'
 NC='\033[0m'
 
+STYLELINT_CONFIG=.stylelintrc
+
 tsfiles=$(git diff --cached --name-only --diff-filter=ACM "*.ts" | tr '\n' ' ')
 htmlfiles=$(git diff --cached --name-only --diff-filter=ACM "*.html" | tr '\n' ' ')
+
 filestoprettify="$tsfiles $htmlfiles"
 
 # || true prevents grep from exit when no matches
 #
 # TODO: Add *.html after migrating to eslint.
 # (on TSLint it leads to "is not included in project" error in some cases)
 #
-filestolint=$(git diff --diff-filter=d --cached --name-only | grep -E '\.(js|ts)$' || true)
+scriptstolint=$(git diff --cached --name-only --diff-filter=d | grep -E '\.(js|ts)$' || true)
+stylestolint=$(git diff --cached --name-only --diff-filter=d | grep -E '\.(scss|css)$' || true)
+
+# TODO: Ideally, we want to lint only staged changes
+#  so that we don't add any random changes that haven't been staged before linting starts
+#  but could be added after auto-fixing lint errors and indexing the same files.
+#  This could be solved via https://github.com/okonet/lint-staged
 
 if [ -n "$tsfiles" ]; then
-  echo "==> Sort imports in .ts files"
+  echo "==> Sorting imports in .ts files"
   echo "$tsfiles" | xargs ./node_modules/.bin/import-sort --write
 
-  echo "==> Prettify .ts, .html files"
+  echo "==> Prettifying .ts, .html files"
   echo "$filestoprettify" | xargs ./node_modules/.bin/prettier --write
 
-  echo "==> Stage formatted .ts, .html files"
+  echo "==> Staging formatted .ts, .html files"
   echo "$filestoprettify" | xargs git add
 
-  echo "==> Check TSLint errors in staged files";
-  echo "$filestolint" | xargs node_modules/tslint/bin/tslint --project tsconfig.json
-  printf "${GREEN}All fine!${NC}\n"
+  echo "==> Checking TSLint errors in staged files";
+  echo "$scriptstolint" | xargs node_modules/tslint/bin/tslint --project tsconfig.json
+  printf "${GREEN}🔨️ Scripts and templates are fine!${NC}\n\n"
+fi;
+
+if [ -f "$STYLELINT_CONFIG" ] && [ -n "$stylestolint" ]; then
+  echo "==> Checking Stylelint errors in staged files";
+  echo "$stylestolint" | xargs ./node_modules/.bin/stylelint --fix
+
+  echo "==> Staging formatted .scss, .css files"
+  echo "$stylestolint" | xargs git add
+
+  printf "${GREEN}💅 Styles are fine!${NC}\n\n"
+fi;
+
+if [ -n "$tsfiles" ] || [ -n "$stylestolint" ]; then
+  printf "${GREEN}===== ✅ Linting passed. Well done!👏🥇 =====${NC}\n\n"
 fi;
 
 exit 0;