Add MainMenu Controller support

[Jannify]

• Make server list controller friendly
• Add delete confirmation for server list
• Make server add window in SN based UI
• Make server add window controller friendly
• Make server join window controller friendly
• Make server password window controller friendly
• Add loading and (error-)message window

From Clement:

• Unable to scroll with the mousewheel through the server listview when it, I need to hover or focus it with a click on the scrollbar to be able to use the mousewheel scroll
• No visual hint that the server has been successfully added to the list using Add Server menu
• No warning before clicking on delete on a serve rentry, which is a bit frustrating when using it accidentaly
• Didn't look if there's a timeout in our code but in the Loading screen might need a Cancel button if it can be a long process
• When joining a reachable server, there's no preview of the color we're choosing that we used to have
• Unable to use tab to switch between entry in server create menu
• Maybe we could add some margin in the server listview between items. The first item is overflowing a bit on the top, you can see if you force the scroll to offset the listview
• Add server button looks like a server entry which could be confusing, maybe we could slightly restyle it or move it elsewhere
• Unable to connect to server text, ip could be centered

Partial-Completes #1653
Closes #1816

[Drakonkinst]

Hi! I'm new here, but I've been reading PRs to get an idea of how this mod is developed. Feel free to take my advice with a grain of salt.

[tornac1234]

Do we want this in for 1.8 ?

[tornac1234]

Currently when we click on a server (to join it) and click on another menu (e.g. Play, Multiplayer) while connecting to the server (first step which is notably long when trying to connect to a server that is not started) there's a loading panel appearing which ends up opening an "unable to connect" panel when failing. But this will still open even if we opened another menu in the meantime. For example if we open options while connecting to a server, when we get the fail message, the menu will try to switch to the multiplayer panel but fail and will leave an empty screen.
A fix for this would to cut connection when exiting the loading tab while connecting to a server.

Also I had some issues while selecting the color picker for some reason, some times it work pretty well, but some times it didn't.

[dartasen]

UI looks better overall

Legend :

• 🔴 Very frustrating
• 🟠 frustrating
• 🟢 Idea

Few suggestions about the UX, leaving that here I don't know how painful is it to do with the code-behind unity API :

• 🔴Unable to scroll with the mousewheel through the server listview when it, I need to hover or focus it with a click on the scrollbar to be able to use the mousewheel scroll
• 🟢 No visual hint that the server has been successfully added to the list using Add Server menu =>
  • Maybe a Log.InGame would do the trick if a proper UI is hard to implement
  • Either add the server at the top of the list or scroll to the entry when it has been added
• 🔴 No warning before clicking on delete on a serve rentry, which is a bit frustrating when using it accidentaly =>
  • A warning popup would do the trick
• 🟠 Didn't look if there's a timeout in our code but in the Loading screen might need a Cancel button if it can be a long process
• 🟠When joining a reachable server, there's no preview of the color we're choosing that we used to have =>
  • Maybe coloring the player name text can be enough if adding back the color rectangle could break the UI
• 🟠 Unable to use tab to switch between entry in server create menu

About the UI :

• 🟢 Maybe we could add some margin in the server listview between items =>
  • The first item is overflowing a bit on the top, you can see if you force the scroll to offset the listview
• 🟢 Add server button looks like a server entry which could be confusing, maybe we could slightly restyle it or move it elsewhere
• 🟢 Unable to connect to server text, ip could be centered

[dartasen]

Would add those edits to improve the look & feel :
MainMenuJoinServerPanel:64

playerNameInputField.textComponent.fontSizeMin = 20;
playerNameInputField.textComponent.fontSize = 20;
playerNameInputField.textComponent.fontSizeMax = 22;

MainMenuJoinServerPanel:77

colorPicker.onColorChange.AddListener((data) => playerNameInputField.textComponent.color = data.color);

Found a crash (doesn't seem to be the case on master) :

• Open Launcher
• Start Game (wait for full launch)
• Start Server
• Server will show a SocketException (LAN Broadcast server trying to bind to a used port)
• Game should crash

Stack trace :

0x00007FFF78BDEC34 (UnityPlayer) UnityMain
0x000001D7F9719E0A (Mono JIT Code) (wrapper managed-to-native) UnityEngine.Mesh:Internal_Create (UnityEngine.Mesh)
0x000001D7F9719D5B (Mono JIT Code) UnityEngine.Mesh:.ctor ()
0x000001D7F9719913 (Mono JIT Code) TMPro.TextMeshProUGUI:Awake ()
0x000001D7838C0FD0 (Mono JIT Code) (wrapper runtime-invoke) object:runtime_invoke_void__this__ (object,intptr,intptr,intptr)
0x00007FFF77E8E290 (mono-2.0-bdwgc) mono_get_runtime_build_info
0x00007FFF77E12AC2 (mono-2.0-bdwgc) mono_perfcounters_init
0x00007FFF77E1BB1F (mono-2.0-bdwgc) mono_runtime_invoke
0x00007FFF78DABCFD (UnityPlayer) UnityMain
0x000001D7F9746B66 (Mono JIT Code) (wrapper managed-to-native) UnityEngine.Object:Internal_CloneSingleWithParent (UnityEngine.Object,UnityEngine.Transform,bool)
0x000001D7F974699B (Mono JIT Code) UnityEngine.Object:Instantiate (UnityEngine.Object,UnityEngine.Transform,bool)
0x000001D7F974688B (Mono JIT Code) UnityEngine.Object:Instantiate<T_REF> (T_REF,UnityEngine.Transform,bool)
0x000001D8010082AB (Mono JIT Code) NitroxClient.MonoBehaviours.Gui.MainMenu.ServersList.MainMenuServerListPanel:CreateServerButton (string,string,int,bool)
0x000001D80107D47B (Mono JIT Code) NitroxClient.MonoBehaviours.Gui.MainMenu.ServersList.MainMenuServerListPanel:<FindLANServersAsync>g__AddButton|37_0 (System.Net.IPEndPoint)
0x000001D80107D314 (Mono JIT Code) NitroxClient.Communication.LANBroadcastClient:OnServerFound (System.Net.IPEndPoint)
0x000001D8010611F3 (Mono JIT Code) NitroxClient.Communication.LANBroadcastClient:<SearchInternalAsync>g__ReceivedResponse|9_0 (System.Net.IPEndPoint,LiteNetLib.NetPacketReader,LiteNetLib.UnconnectedMessageType)
0x000001D80106103E (Mono JIT Code) LiteNetLib.EventBasedNetListener:LiteNetLib.INetEventListener.OnNetworkReceiveUnconnected (System.Net.IPEndPoint,LiteNetLib.NetPacketReader,LiteNetLib.UnconnectedMessageType)
0x000001D801060BC6 (Mono JIT Code) LiteNetLib.NetManager:ProcessEvent (LiteNetLib.NetEvent)
0x000001D801030963 (Mono JIT Code) LiteNetLib.NetManager:PollEvents ()
0x000001D801030083 (Mono JIT Code) NitroxClient.Communication.LANBroadcastClient/<>c__DisplayClass9_0/<<SearchInternalAsync>b__2>d:MoveNext ()

[dartasen]

Works fine (apart from the crash)

[Measurity]

Minor things, otherwise LGTM CW

Old review

[tornac1234]

• Instant launch doesn't work anymore :( (pls fix)
• click on a server, it says "loading", quickly click on "options", now it's supposed to write "unable to connect", but the whole subnautica screen disappears. to fix you might want to adapt the "on connection established callback" to manage the case where the MainMenuRightSide is not open
• should we not have 11000 as a default/placeholder server PORT when creating a server ?