Sync infection anim #2213
Open
Sync infection anim #2213
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting AnimationChangeEvent processor(added new enum value)
…is untested as of now
…routine to automatically time sending the end infection sync animation packet
Measurity
requested changes
Dec 27, 2024
Nitrox.Test/Patcher/Patches/Dynamic/InfectionReveal_PatchTest.cs
Outdated
Show resolved
Hide resolved
…ck, saves some lines Co-authored-by: Measurity <[email protected]>
Co-authored-by: Measurity <[email protected]>
…erTest class to implement new testing method in this PR
Measurity
reviewed
Dec 29, 2024
…m running twice on remote clients
|
tested in game, both through infectionreveal command and through normal story triggers, both seem to work(tested with 2 clients), just need a final code review from @Measurity and then good to merge |
Jannify
requested changes
Dec 29, 2024
|
|
||
| public sealed partial class InfectionReveal_Patch : NitroxPatch, IDynamicPatch | ||
| { | ||
| internal static readonly MethodInfo TARGET_METHOD = AccessTools.EnumeratorMoveNext(Reflect.Method((Player t) => t.TriggerInfectionRevealAsync())); |
There was a problem hiding this comment.
Made internal since it can't be made private due to being defined in a namespace
There was a problem hiding this comment.
You sure? How can https://github.com/SubnauticaNitrox/Nitrox/blob/master/NitroxPatcher/Patches/Dynamic/BreakableResource_BreakIntoResources_Patch.cs then have it private.
Co-authored-by: Jannify <[email protected]>
Co-authored-by: Jannify <[email protected]>
Co-authored-by: Jannify <[email protected]>
…oxModdedUnofficial into sync-infection-anim
Co-authored-by: Jannify <[email protected]>
|
Tested in-game again, good for what will (hopefully) be the green round of reviews |
Jannify
requested changes
Dec 30, 2024
NitroxPatcher/Patches/Dynamic/Player_TriggerInfectionRevealAsync_Patch.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what the title says. The story goals are already synced through StoryGoalExecuted packets and processors, but the animation wasn't. Uses a transpiler to trigger sending the AnimChangeEvent packet to start the animation and then just uses a coroutine to time the ending animation packet with the fixed duration of the animation(12 seconds). Ready for reviews code-wise at this time and should theoretically work, builds and seems to run fine but haven't been able to test properly yet.