Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing looping fire sound and unauthenticated SetIntroCinematicMode packet #2215

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Fixing looping fire sound and unauthenticated SetIntroCinematicMode packet #2215

merged 3 commits into from
Dec 30, 2024

Conversation

Jannify
Copy link
Member

@Jannify Jannify commented Dec 28, 2024 •
edited
Loading

Tested with:

  • Skipping single player intro
  • Playing single player intro
  • Playing duo intro
  • Joining after intro played/second joining
  • Joining with creative mode
  • Joined with DEBUG build option

Coding-Hen
Coding-Hen approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@Coding-Hen Coding-Hen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMCW

@dartasen dartasen linked an issue Dec 30, 2024 that may be closed by this pull request
Fixed status of escape pod doesn't save/load and still plays the alarm sound #2200
Closed
@dartasen dartasen requested a review from tornac1234 December 30, 2024 14:04
dartasen
dartasen approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@dartasen dartasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine IG

Note aside it's really disturbing to not have fire/extinguisher synced at the end of the cinematic 🧑‍🚒

@dartasen dartasen merged commit 7f36da6 into SubnauticaNitrox:master Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dartasen dartasen dartasen approved these changes

@Coding-Hen Coding-Hen Coding-Hen approved these changes

@tornac1234 tornac1234 Awaiting requested review from tornac1234

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixed status of escape pod doesn't save/load and still plays the alarm sound
3 participants
@Jannify @Coding-Hen @dartasen