fix: make Client(insecure=True) affect login & logout

[oleobal]

Summary

Currently instantiating a Client with insecure=True (which disables SSL verification) will still fail you at login if you have an invalid TLS certificate. This fixes that.

Please check if the PR fulfills these requirements

• If necessary, the changelog has been updated
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• The commit message follows the conventional commit specification
• For any breaking changes, companion PRs have been opened on the following repositories:
  • substra-tests
  • substrafl
  • substra-documentation

[SdgJlbl]

Thanks for the PR 🙏
Do you think we can add a small, non-regression unit test?

[oleobal]

@SdgJlbl

Do you think we can add a small, non-regression unit test?

I'm not sure how to test this, do you know how I can test connecting to a target with a self-signed certificate?

[SdgJlbl]

@SdgJlbl

Do you think we can add a small, non-regression unit test?

I'm not sure how to test this, do you know how I can test connecting to a target with a self-signed certificate?

I think I would mock the call to requests.post and check that the arguments are what I expect.

It's not ideal and mocking and all, but at least it will raises if someone forgets to keep all the kwargs in a future refactoring.

[SdgJlbl]

Thanks