Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert round_idx metadata to int in Performances #387

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix: convert round_idx metadata to int in Performances #387

merged 3 commits into from
Sep 12, 2023

Conversation

ThibaultFy
Copy link
Member

Related issue

# followed by the number of the issue

Summary

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@ThibaultFy ThibaultFy marked this pull request as ready for review September 12, 2023 09:03
@ThibaultFy ThibaultFy requested a review from a team as a code owner September 12, 2023 09:03
SdgJlbl
SdgJlbl approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the context of the fix, out of curiosity?

@ThibaultFy
Copy link
Member Author

Member

I got these warnings when running the examples locally...

image

@ThibaultFy ThibaultFy merged commit 78127d9 into main Sep 12, 2023
5 checks passed
@ThibaultFy ThibaultFy deleted the fix/pydantic-warning branch September 12, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThibaultFy @SdgJlbl