Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 0.48.1 #391

Merged
merged 1 commit into from
Oct 6, 2023
Merged

chore: release 0.48.1 #391

merged 1 commit into from
Oct 6, 2023

Conversation

thbcmlowk
Copy link
Contributor

Related issue

# followed by the number of the issue

Summary

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@thbcmlowk thbcmlowk changed the title chore: release 0.48.1rc1 chore: release 0.48.1 Oct 2, 2023
@thbcmlowk thbcmlowk marked this pull request as ready for review October 6, 2023 09:52
@thbcmlowk thbcmlowk requested a review from a team as a code owner October 6, 2023 09:52
ThibaultFy
ThibaultFy requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to update substra-tools deps to enforce the new version of the docker images

@thbcmlowk
Copy link
Contributor Author

thbcmlowk commented Oct 6, 2023 •
edited
Loading

I think we want to update substra-tools deps to enforce the new version of the docker images

Missed that it was a dev dependency, but actually asked myself how it was enforced. Should I just do:

            "substratools>=0.21.0",

In extra_requires?

@thbcmlowk
chore: release 0.48.1
83da868 
Signed-off-by: Thibault Camalon <[email protected]>
ThibaultFy
ThibaultFy approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep perfect!

@thbcmlowk thbcmlowk merged commit 05a38a2 into main Oct 6, 2023
5 checks passed
@thbcmlowk thbcmlowk deleted the release-0.48.1 branch October 6, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaultFy ThibaultFy ThibaultFy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thbcmlowk @ThibaultFy