-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rename function to archive #393
Conversation
a9673b4
to
ef92a1d
Compare
/e2e help |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
But there is a mention to it in SubstraFL. You need to open a companion PR there too:
https://github.com/Substra/substrafl/blob/3f4434a11288ab416afaf33a5800cc2c120d83f0/tests/remote/register/test_register.py#L74
This is the only mention I found so it might just be a one line PR :) (I looked in substra tests, subtrafl and substra-doc)
Nice catch 👍 I'm wondering if I might need to change some things in substra-tests too, in the factory possibly... 😭 |
I looked and didn't find any :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. To be merged with the POC functions then ? (which mean we'll need to release substra too ?)
Not with the POC branch, it's the next bunch of PRs (adding checksums, permission checks and a bit of refactoring / renaming) 😅 I anticipate lots of fun to rebase all that 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1dce7e7
to
6e6a9da
Compare
Signed-off-by: SdgJlbl <[email protected]>
6e6a9da
to
ce12f8c
Compare
Signed-off-by: SdgJlbl <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
2cd4f9e
to
307bb0c
Compare
Signed-off-by: ThibaultFy <[email protected]>
307bb0c
to
238e116
Compare
Companion PRs
Substra/orchestrator#310
Substra/substra-backend#739