Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: from setup to pyproject #407

Merged
merged 6 commits into from
Mar 25, 2024
Merged

chore: from setup to pyproject #407

merged 6 commits into from
Mar 25, 2024

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented Mar 25, 2024 •
edited
Loading

Related issue

part of FL-1188

Summary

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@ThibaultFy ThibaultFy force-pushed the from-setup-to-pyproject branch from 639661b to 3283a87 Compare March 25, 2024 13:47
@ThibaultFy
Copy link
Member Author

/e2e --tests sdk

@Owlfred
Copy link

Owlfred commented Mar 25, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

@linear Linear
Copy link

linear bot commented Mar 25, 2024

FL-1188 From setup.py to pyproject.toml

@ThibaultFy ThibaultFy marked this pull request as ready for review March 25, 2024 15:14
@ThibaultFy ThibaultFy requested a review from a team as a code owner March 25, 2024 15:14
SdgJlbl
SdgJlbl reviewed Mar 25, 2024
View reviewed changes
pyproject.toml
requires-python = ">= 3.9"
dependencies = [
"requests",
"urllib3<2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting 🙃
I guess this was pinned to avoid a bug at some point, might be worth investigating if it's still necessary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth create a card you think ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, probably, else we'll forget about it again :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ThibaultFy ThibaultFy merged commit 88854ac into main Mar 25, 2024
5 checks passed
@ThibaultFy ThibaultFy deleted the from-setup-to-pyproject branch March 25, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaultFy @Owlfred @SdgJlbl