Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add python 3.11 support #169

Merged
merged 7 commits into from
Oct 9, 2023
Merged

chore: add python 3.11 support #169

merged 7 commits into from
Oct 9, 2023

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented Sep 20, 2023 •
edited
Loading

This was referenced Sep 25, 2023
Merged
Merged
Merged
Merged
@ThibaultFy ThibaultFy marked this pull request as ready for review September 25, 2023 14:53
@ThibaultFy ThibaultFy requested a review from a team as a code owner September 25, 2023 14:53
SdgJlbl
SdgJlbl reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing on the substra repo, probably worth launching e2e tests to be sure.

@Substra Substra deleted a comment from Owlfred Sep 29, 2023
@Substra Substra deleted a comment from Owlfred Sep 29, 2023
@Substra Substra deleted a comment from Owlfred Sep 29, 2023
@ThibaultFy
Copy link
Member Author

/e2e --tests sdk,substrafl,doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11 --benchmarks mnist,camelyon

@Owlfred
Copy link

Owlfred commented Oct 2, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / standalone-camelyon: ✔️
  • Dispatch Jobs: ✔️
  • Distributed: ⏭️
  • Documentation / standalone-doc: ❌
  • MNIST / standalone-mnist: ✔️
  • Standalone / standalone-sdk: ✔️
  • SubstraFL / standalone-substrafl: ✔️

Not this time.

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk,substrafl,doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11 --benchmarks mnist,camelyon

@Owlfred
Copy link

Owlfred commented Oct 3, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / standalone-camelyon: ✔️
  • Dispatch Jobs: ✔️
  • Distributed: ⏭️
  • Documentation / standalone-doc: ❌
  • MNIST / standalone-mnist: ❌
  • Standalone / standalone-sdk: ✔️
  • SubstraFL / standalone-substrafl: ✔️

“Boy, that escalated quickly.” ― Ron Burgundy, Anchorman: The Legend of Ron Burgundy

@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@Substra Substra deleted a comment from Owlfred Oct 3, 2023
@ThibaultFy
Copy link
Member Author

ThibaultFy commented Oct 3, 2023 •
edited
Loading

GKE 1.26

/e2e --tests sdk,substrafl,doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11 --benchmarks mnist,camelyon

@Owlfred
Copy link

Owlfred commented Oct 3, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / standalone-camelyon: ✔️
  • Dispatch Jobs: ✔️
  • Distributed: ⏭️
  • Documentation / standalone-doc: ❌
  • MNIST / standalone-mnist: ❌
  • Standalone / standalone-sdk: ❌
  • SubstraFL / standalone-substrafl: ✔️

Darn it.

@ThibaultFy
Copy link
Member Author

GKE 1.27

/e2e --tests sdk,substrafl,doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11 --benchmarks mnist,camelyon

@Owlfred
Copy link

Owlfred commented Oct 3, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / standalone-camelyon: ✔️
  • Dispatch Jobs: ✔️
  • Distributed: ⏭️
  • Documentation / standalone-doc: ❌
  • MNIST / standalone-mnist: ✔️
  • Standalone / standalone-sdk: ❌
  • SubstraFL / standalone-substrafl: ✔️

Sorry, try again.

@ThibaultFy
Copy link
Member Author

/e2e --tests doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11

@Owlfred
Copy link

Owlfred commented Oct 4, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

“Boy, that escalated quickly.” ― Ron Burgundy, Anchorman: The Legend of Ron Burgundy

@ThibaultFy
Copy link
Member Author

/e2e --tests doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11

@Owlfred
Copy link

Owlfred commented Oct 4, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

Better luck next time!

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk,substrafl,doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11 --benchmarks mnist,camelyon

@Owlfred
Copy link

Owlfred commented Oct 4, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / standalone-camelyon: ✔️
  • Dispatch Jobs: ✔️
  • Distributed: ⏭️
  • Documentation / standalone-doc: ❌
  • MNIST / standalone-mnist: ✔️
  • Standalone / standalone-sdk: ✔️
  • SubstraFL / standalone-substrafl: ✔️

“I’m sorry, Dave. I’m afraid I can’t do that.” ― Hal, 2001: A Space Odyssey

@ThibaultFy
Copy link
Member Author

/e2e --tests doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11

@Owlfred
Copy link

Owlfred commented Oct 4, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

I'm sorry.

@ThibaultFy
Copy link
Member Author

/e2e --tests doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11

@Owlfred
Copy link

Owlfred commented Oct 4, 2023 •
edited
Loading

End to end tests: ✔️ SUCCESS

“I love it when a plan comes together.” ― Colonel John “Hannibal” Smith, The A-Team

@linear
Copy link

linear bot commented Oct 4, 2023

FL-979 Support Python 3.11

Add the support for Python 3.11 after adding the support to Pytorch 2.0 in the substrafl examples and benchmark.

  • Add substra-tools image for 3.11
  • Add python 3.11 to Github actions matrices
  • Add info to documentation
  • Add version to remgister.py version check in SubstraFL (l.40)

Blocked by FL-975

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk,substrafl,doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11 --benchmarks mnist,camelyon

@Owlfred
Copy link

Owlfred commented Oct 5, 2023 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / standalone-camelyon: ✔️
  • Dispatch Jobs: ✔️
  • Distributed: ⏭️
  • Documentation / standalone-doc: ✔️
  • MNIST / standalone-mnist: ❌
  • Standalone / standalone-sdk: ✔️
  • SubstraFL / standalone-substrafl: ✔️

Not this time.

@ThibaultFy
Copy link
Member Author

/e2e --tests sdk,substrafl,doc --mode standalone --refs substra=python-3-11,substra-tests=python-3-11,substra-ci=python-3-11,substra-documentation=python-3-11 --benchmarks mnist,camelyon

@Owlfred
Copy link

Owlfred commented Oct 5, 2023 •
edited
Loading

End to end tests: ✔️ SUCCESS

Awesome sauce!

@ThibaultFy
chore: add python 3.11 support
cd05896 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: changelog
cd7d20f 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: bump sklearn
8fbe3f1 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: bump numpy
d2aacb0 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: bump torch & torchvision
1a919b4 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: bump numpy in setup.py
46c11c4 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy
chore: fix enum
8822244 
Signed-off-by: ThibaultFy <[email protected]>
@ThibaultFy ThibaultFy merged commit 172b42e into main Oct 9, 2023
7 checks passed
@ThibaultFy ThibaultFy deleted the python-3-11 branch October 9, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaultFy @Owlfred @SdgJlbl