Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tux' sliding behavior #2795

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

Brockengespenst
Copy link
Contributor

@Brockengespenst Brockengespenst commented Feb 21, 2024

  • Do smooth transition on slope angle change
  • Continue to use slidejump animation when releasing jump button during slidejump
  • Fix animation glitches in transition from crawling to sliding
  • Add possibility to pause/resume animations and apply this for crawling and climbing when not moving

Fixes #2785
Fixes #2723

@Rusty-Box
Copy link
Member

This already feel much, much better! Thank you. Sorry again if I came off as rude in my issue. I was just a bit upset with how fast this got merge without proper testing by the team. Luckily you worked on a fix pretty quickly! Thanks again :)

@Rusty-Box Rusty-Box added category:code status:needs-review Work needs to be reviewed by other people labels Feb 22, 2024
@mrkubax10
Copy link
Member

I was just a bit upset with how fast this got merge without proper testing by the team.

Yes, I admit that this was my fault because it was me who merged it too quickly. Next time I won't do that.

@Brockengespenst
Copy link
Contributor Author

This already feel much, much better! Thank you. Sorry again if I came off as rude in my issue. I was just a bit upset with how fast this got merge without proper testing by the team. Luckily you worked on a fix pretty quickly! Thanks again :)

No problem. Luckily this motivated me more than it frustrated me. ;-)

@Brockengespenst
Copy link
Contributor Author

I added some changes to improve the transition from crawling to sliding and vice versa, this looks much smoother now.
Additionally when not moving left or right while crawling, the duck animation will not be displayed, but the crawling animation will just be stopped. If starting to crawl again, the crawl animation is continued. This feels more natural for me as Tux stays in the crawl position as long as the down button is pressed.

@Brockengespenst Brockengespenst marked this pull request as ready for review February 23, 2024 19:44
@Rusty-Box
Copy link
Member

This does look pretty good - one question though: You think you could make it pause on the last frame shown? RIght now Tux always goes to (I presume) the first frame of his crawling animation. It would give it an even more natural look, if it would pause the animation at the frame it was last. If that isn't too much of a hassle do - something the climbing animation would also greatly benefit from.

Otherwise this is great! 👍

@Rusty-Box
Copy link
Member

I do think I found another bug! If you die when the sprite is rotated, Tux's death animation will also be rotated.

* Do smooth transition on slope angle change
* Continue to use slidejump animation when releasing jump button during
slidejump
@Brockengespenst
Copy link
Contributor Author

I do think I found another bug! If you die when the sprite is rotated, Tux's death animation will also be rotated.

Thanks, that is a good catch. I fixed it.

You think you could make it pause on the last frame shown?
something the climbing animation would also greatly benefit from.

I added the possibility to pause / resume sprite animations and applied that to crawling and climbing. This looks indeed much better now. Please test and check if this fits your expectations.

@Rusty-Box
Copy link
Member

There this is one issue that it causes right now. After you an animation got paused during crawling or climbing and you proceed to do something else Tux will now be forever stuck on the first frame of each animation for the rest of the level.

@Brockengespenst
Copy link
Contributor Author

Uh, sorry. I guess it was a bit too late yesterday. Now the animation is automatically continued when another action is set. I guess this is the most intuitive behavior and fixes the issue.

@RustoMCSpit
Copy link

there should also be particle effects depending on the environment. if theyre in snow and going fast, snow should come off their trail

@RustoMCSpit
Copy link

is there any way this can be incorporated into level design where tux has to gain momentum with slopes

Copy link
Member

@Rusty-Box Rusty-Box left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. All seems to be good now! :)

@Rusty-Box Rusty-Box merged commit 3b76c48 into SuperTux:master Feb 26, 2024
33 checks passed
@mrkubax10 mrkubax10 removed the status:needs-review Work needs to be reviewed by other people label Feb 26, 2024
@Brockengespenst Brockengespenst deleted the improve_slide_rotation branch February 26, 2024 18:42
@RustoMCSpit
Copy link

when will the flatpak see this change?

@tobbi
Copy link
Member

tobbi commented May 2, 2024

I checked on flathub and saw that there's only released versions on there, so most likely later this year when we release a stable version.

You can get nightly builds from http://download.supertux.org

@RustoMCSpit
Copy link

I checked on flathub and saw that there's only released versions on there, so most likely later this year when we release a stable version.

You can get nightly builds from http://download.supertux.org

any reason for that? is the build unstable??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants