-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Tux' sliding behavior #2795
Improve Tux' sliding behavior #2795
Conversation
This already feel much, much better! Thank you. Sorry again if I came off as rude in my issue. I was just a bit upset with how fast this got merge without proper testing by the team. Luckily you worked on a fix pretty quickly! Thanks again :) |
Yes, I admit that this was my fault because it was me who merged it too quickly. Next time I won't do that. |
No problem. Luckily this motivated me more than it frustrated me. ;-) |
I added some changes to improve the transition from crawling to sliding and vice versa, this looks much smoother now. |
This does look pretty good - one question though: You think you could make it pause on the last frame shown? RIght now Tux always goes to (I presume) the first frame of his crawling animation. It would give it an even more natural look, if it would pause the animation at the frame it was last. If that isn't too much of a hassle do - something the climbing animation would also greatly benefit from. Otherwise this is great! 👍 |
I do think I found another bug! If you die when the sprite is rotated, Tux's death animation will also be rotated. |
* Do smooth transition on slope angle change * Continue to use slidejump animation when releasing jump button during slidejump
541fc49
to
2d65a0a
Compare
Thanks, that is a good catch. I fixed it.
I added the possibility to pause / resume sprite animations and applied that to crawling and climbing. This looks indeed much better now. Please test and check if this fits your expectations. |
There this is one issue that it causes right now. After you an animation got paused during crawling or climbing and you proceed to do something else Tux will now be forever stuck on the first frame of each animation for the rest of the level. |
2d65a0a
to
a2f2e59
Compare
Uh, sorry. I guess it was a bit too late yesterday. Now the animation is automatically continued when another action is set. I guess this is the most intuitive behavior and fixes the issue. |
there should also be particle effects depending on the environment. if theyre in snow and going fast, snow should come off their trail |
is there any way this can be incorporated into level design where tux has to gain momentum with slopes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. All seems to be good now! :)
when will the flatpak see this change? |
I checked on flathub and saw that there's only released versions on there, so most likely later this year when we release a stable version. You can get nightly builds from http://download.supertux.org |
any reason for that? is the build unstable?? |
Fixes #2785
Fixes #2723