Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile COPY failed #490

Closed
wants to merge 1 commit into from
Closed

Update Dockerfile COPY failed #490

wants to merge 1 commit into from

Conversation

FDiskas
Copy link

@FDiskas FDiskas commented Jan 19, 2021 •
edited
Loading

FIX:

ERROR: Service 'php' failed to build: COPY failed: stat /var/lib/docker/***/composer.lock: no such file or directory

on first run docker-compose up

@FDiskas
Update Dockerfile
017691d 
FIX: `ERROR: Service 'php' failed to build: COPY failed: stat /var/lib/docker/tmp/docker-builder210691310/composer.lock: no such file or directory` on first run `docker-compose up`
@FDiskas FDiskas requested a review from a team as a code owner January 19, 2021 18:55
@FDiskas
Copy link
Author

FDiskas commented Jan 20, 2021

If I check container content I see that all correct files where copied
image

tarnawski
tarnawski reviewed May 26, 2021
View reviewed changes
Dockerfile
@@ -76,7 +76,7 @@ WORKDIR /srv/sylius
ARG APP_ENV=prod

# prevent the reinstallation of vendors at every changes in the source code
COPY composer.json composer.lock symfony.lock ./
COPY composer.json *.lock ./
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, all files with the suffix .lock will be copied. IMHO better approach is proposed here #559 where we limit files to composer only.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about yarn.lock ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock is copied a couple of lines below

Sylius-Standard/Dockerfile

Line 124 in 017691d

COPY package.json yarn.lock ./

@lchrusciel
Copy link
Member

Hey @FDiskas,

thanks for your proposal and sorry for the lack of activity from our side. We are not docker specialists and it is hard to review these PRs. Can you check, if the problem, that you were trying to fix still exists after the merge of #536?

@lchrusciel lchrusciel added Bug Docker Docker-related issues and PRs. labels May 28, 2021
@lchrusciel
Copy link
Member

Hey @FDiskas,

from what I know, this should be already fixed on master. Nonetheless, thanks a lot for your contribution.

@lchrusciel lchrusciel closed this Sep 23, 2021
@FDiskas FDiskas deleted the patch-2 branch February 16, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarnawski tarnawski tarnawski left review comments

Assignees
No one assigned
Labels
Bug Docker Docker-related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FDiskas @lchrusciel @tarnawski