-
Notifications
You must be signed in to change notification settings - Fork 7
add vagrantfile and build script to create a VM using docker #185
base: master
Are you sure you want to change the base?
Conversation
scripts/bootstrap_ubuntu_docker.sh
Outdated
|
||
|
||
# add sirfuser to the group docker | ||
sudo groupadd docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly this is not needed because the group is added when installing docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. why would we not do this in the normal Vagrantfile and have docker always installed?
This VM installs only docker and few more bits like GNOME. All SIRF prerequisites are then installed by docker. |
ah ok. sorry, I misunderstood. ok. I think it would be worth adding any docker config to the normal VM (probably only the docker group and adding sirfuser to it). That way people don't trip up there. Although you won't like it, I really don't think that this VM should become the standard one. A VM that just wraps docker seems inefficient. Linux/MacOS users don't need it. Windows users who refuse to enable HyperV could, but Docker doesn't recommend it. (It seems that the previous docker Windows workaround which effectively was running it in VirtualBox is no longer available). In my mind, the VM and the docker instance serve 2 different purposes.
So, I'm happy with PR as an experiment for crazy people like us. And we can merge it as long as the doc makes it clear what is what. But I don't think we should distributed this VM. |
Actually the real reason I need this is that, because I'm forced to use VirtualBox to create the normal VM, I cannot use docker on my windows laptop. I thought that trying to do things to the docker files without testing would be a bad idea, so I resorted to create a Virtualbox VM for the sole purpose of running docker... :D |
sure. (I just did the same on my normal VM, after attaching another disk). |
# accessing "localhost:8080" will access port 80 on the guest machine. | ||
|
||
# Forward port for jupyter notebooks | ||
config.vm.network "forwarded_port", guest: 8888, host: 8889 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guest
should be 9999 as jupyter on the docker instance responds to port 8888, which is forwarded to 9999.
Host: 8889 -> VirtualBox 9999 -> docker 8888
No description provided.