Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contextDocument handling in ColumnSizing feature #5747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve contextDocument handling in ColumnSizing feature #5747

wants to merge 2 commits into from

Conversation

parassantra
Copy link

@parassantra parassantra commented Sep 16, 2024 •
edited
Loading

What's this PR

#5746

Enhance the contextDocument assignment logic in the ColumnSizing feature:

  • Use provided _contextDocument if available
  • Fall back to event target's ownerDocument if possible
  • Use global document as a last resort
  • Handle cases where document is undefined

This change improves compatibility with different environments and provides
more robust document reference handling for column resizing events.

@parassantra
Copy link
Author

@KevinVandy Please review when you have time.

@antoniobeltran
Copy link

Plus 1 on this. Following for updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parassantra @antoniobeltran