Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit dependency on SciMLBase #256

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Conversation

giordano
Copy link
Member

I believe the reason why we're getting failures in the test with Julia v1.10 in #254 is because the combination of packages [email protected] + [email protected] is allowed by the registry but in practice incompatible. While I believe this should be fixed in the registry by not to allow getting incompatible versions, we should be able to work around the issue by just not requiring SciMLBase explicitly and allow the registry to pull more up-to-date versions, with fewer constraints.

Haven't tested locally, but I'm moderately confident this should do the trick.

@giordano giordano changed the title Bump to version 1.1.0 Remove explicit dependency on SciMLBase Mar 12, 2024
Copy link
Member

@matt-graham matt-graham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me and 🤞 it fixes the issue

@matt-graham
Copy link
Member

With regards to FillArrays - haven't tested recently, but previously I found that something in how I was using FillArrays with Distributions was causing a bug in the Lorenz 63 model implementation whereby the updates across particles were ending up coupled unintentionally so #252 removes the dependency on FillArrays in favour of initializing explicitly. So could potentially merge those changes here and remove FillArrays dependency altogether?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (4a71c4f) to head (90da078).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           mmg/bump-to-v1.1.0     #256      +/-   ##
======================================================
- Coverage               94.05%   92.48%   -1.57%     
======================================================
  Files                       7        7              
  Lines                     353      386      +33     
======================================================
+ Hits                      332      357      +25     
- Misses                     21       29       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-graham matt-graham merged commit 9d95422 into mmg/bump-to-v1.1.0 Mar 12, 2024
6 of 8 checks passed
@matt-graham matt-graham deleted the mg/rm-sciml branch March 12, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants