-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove explicit dependency on SciMLBase
#256
Conversation
SciMLBase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me and 🤞 it fixes the issue
With regards to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## mmg/bump-to-v1.1.0 #256 +/- ##
======================================================
- Coverage 94.05% 92.48% -1.57%
======================================================
Files 7 7
Lines 353 386 +33
======================================================
+ Hits 332 357 +25
- Misses 21 29 +8 ☔ View full report in Codecov by Sentry. |
I believe the reason why we're getting failures in the test with Julia v1.10 in #254 is because the combination of packages
[email protected]
+[email protected]
is allowed by the registry but in practice incompatible. While I believe this should be fixed in the registry by not to allow getting incompatible versions, we should be able to work around the issue by just not requiringSciMLBase
explicitly and allow the registry to pull more up-to-date versions, with fewer constraints.Haven't tested locally, but I'm moderately confident this should do the trick.