Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Demo auth #12

Merged
merged 1 commit into from
Nov 20, 2023
Merged

✨ Demo auth #12

merged 1 commit into from
Nov 20, 2023

Conversation

ThatXliner
Copy link
Member

@ThatXliner ThatXliner commented Nov 18, 2023 •
edited
Loading

realjoshuau
realjoshuau reviewed Nov 20, 2023
View reviewed changes
apps/web/app/page.tsx
export default async function Index() {
const cookieStore = cookies();
const client = createClient(cookieStore);
if ((await client.auth.getUser()).data.user == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :: Could we get a wrapper for this?

realjoshuau
realjoshuau approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@realjoshuau realjoshuau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was unable to test due to the Supabase instance not sending email, but it seems fine. No mobile auth is fine for now, I'll make another issue regarding that in a bit.

@realjoshuau realjoshuau merged commit e465cf7 into main Nov 20, 2023
1 of 2 checks passed
@ThatXliner
Copy link
Member Author

LGTM. Was unable to test due to the Supabase instance not sending email, but it seems fine. No mobile auth is fine for now, I'll make another issue regarding that in a bit.

You don’t need to test on production. Production server should just work if the redirect urls are configured properly. Local Supabase doesn’t send emails

@ThatXliner
Copy link
Member Author

LGTM. Was unable to test due to the Supabase instance not sending email, but it seems fine. No mobile auth is fine for now, I'll make another issue regarding that in a bit.

You don’t need to test on production. Production server should just work if the redirect urls are configured properly. Local Supabase doesn’t send emails

On second thought, perhaps only the official hosted Supabase has that email feature built-in to “just work.” Further research is needed

@realjoshuau
Copy link
Member

LGTM. Was unable to test due to the Supabase instance not sending email, but it seems fine. No mobile auth is fine for now, I'll make another issue regarding that in a bit.

You don’t need to test on production. Production server should just work if the redirect urls are configured properly. Local Supabase doesn’t send emails

On second thought, perhaps only the official hosted Supabase has that email feature built-in to “just work.” Further research is needed

Yeah, I have an SMTP server setup on AWS, I just need to hook it up to Supabase, which I'l probably do now or after class today.

@realjoshuau realjoshuau deleted the basic-auth branch November 20, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realjoshuau realjoshuau realjoshuau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auth
2 participants
@ThatXliner @realjoshuau