Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Grade Crossing Math #1475

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Fixed Grade Crossing Math #1475

merged 1 commit into from
Jun 8, 2024

Conversation

km00700
Copy link
Member

@km00700 km00700 commented Apr 14, 2024

Manipulated terms in Grade crossing math to reduce chained operations. Symmetrized behavior for positive and negative values of q to make grade crossing heights symmetrical on both sides of track.
2024-04-14_01 48 13

Manipulated terms in Grade crossing math to reduce chained operations. Symmetrized behavior for positive and negative values of q to make grade crossing heights symmetrical on both sides of track.
@km00700 km00700 requested a review from cam72cam April 14, 2024 09:11
@km00700 km00700 self-assigned this Apr 14, 2024
@cam72cam
Copy link
Member

cam72cam commented Jun 8, 2024

Hey @km00700, sorry it's taken me a while to get to this! Have you tested with different gauges? Where does 0.306 come from?

@km00700
Copy link
Member Author

km00700 commented Jun 8, 2024

I tested it on gauges from model to Ludicrous. (10m)
0.306 came from closely matching the original function in Desmos.

@cam72cam cam72cam merged commit 42c93ca into master Jun 8, 2024
2 checks passed
@cam72cam cam72cam deleted the crossing-fix branch June 8, 2024 21:04
Goldenfield192 added a commit to Goldenfield192/ImmersiveRailroading that referenced this pull request Jun 19, 2024
Merge pull request TeamOpenIndustry#1475 from TeamOpenIndustry/crossing-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants