-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from isopen #34
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_uint(32) is sure enough for subwallet_id?
subwallet_id::uint32 -> subwallet_id::uint64
https://t.me/d_code/15131
https://t.me/durov/167
Duplicate in readme
Suggestion to use Security Policy
In my opinion, the beginning of the comment is superfluous
508baef
.tlb schema update
[uint32 -> uint64] in readme
Question about the license
Possible desynchronization in operations with toncoin (method send_money)
Tonkoins did not arrive to the addressee, but the sender's balance changed to a new value.
ddd4cf7 4632549
Exception refactoring (moved errors to constants)
Pointless comment
In case of negative royalty
https://github.com/DavidAnson/markdownlint/blob/v0.26.2/doc/Rules.md#md034
Small refactoring
After the contest:
15. 3611bd0
Made a merge with the main branch to be without conflict. I use a constant
err::invalid_length
common.fc::throw_unless(err::invalid_length, i); ;; should not start with \0