Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action - Publish package and symbols to nuget #105

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jeffward01
Copy link
Collaborator

Hey, im not quite sure how to test this - I cant seem to update this action: https://github.com/Testura/Testura.Code/actions/runs/3610621665/workflow to the one that I am suggesting for testing.

Notes

  • The one i have in this PR also 'increments' the patch number

    • Example: Major.Minor.Path --> 1.2.3 (3 is the patch number)
    • Not sure if we want to have this, its helpful for small things, but also maybe we want more control.
  • I have the Build and the Publish commented out so that I can test it

Future things:

  • We should include 'Source.Link' nuget package - what do you think?
  • I'd like to also include a .symbols.nupkg or .pdb package.
    • I know for my personal stuff and work, I use Source.Link and .symbols.nupkg, I was having issues with .pdb working with deterministic builds, or perhaps it was another issue I had, but basically I had issues with .pdb with my personal and work projects, so I used .symbols.nupkg -- of course it would be better to do .pdb, but .symbols.nupkg is sufficent

@jeffward01 jeffward01 changed the title Jeffward01 patch 1 Github Action - Publish package and symbols to nuget Dec 3, 2022
@MilleBo
Copy link
Contributor

MilleBo commented Dec 7, 2022

Interesting how similiar it looks to yaml pipelines in azure devops (guess they use some kind of similar standard).

The one i have in this PR also 'increments' the patch number
Example: Major.Minor.Path --> 1.2.3 (3 is the patch number)
Not sure if we want to have this, its helpful for small things, but also maybe we want more control.

This is a hard one and I guess it depends a lot on what kind of project you have. In our case we do so few new changes (for now at least) that it maybe its just easier to change this manually? Like we change the version in the project file and then use that as nuget version? But i guess it could be discussed which one is best.

In some projects I take the super easy road by just going by the generrated build number/date but I dont think that is a good fit here.

I saw this line as well:

Import-Module .\build\GetBuildVersion.psm1

And what I can see we dont have a file like that in the repo?

We should include 'Source.Link' nuget package - what do you think?

I had never actually used that but read up a bit on it now and seems like a nice alternative to pdb so I think we should try it if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants