-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add functionality for writing compilation output to a Stream #44
base: master
Are you sure you want to change the base?
add functionality for writing compilation output to a Stream #44
Conversation
I'm not entirely sure about the API yet. This PR has minimal consequences to the API but can be a littie confusing... I would like to argue for non-async counterparts but that would make the code a little more confusing to maintain. Perhaps all Compile methods should just be named something like is? This makes more use of overloading. So you would have something like:
And possibly their non-async/sync counterparts |
Yeah I guess the API could use some streamlining here. I like your suggestions - it's a bit harder to grab by just looking at the methods but it's more clean so it should work with proper documentation. You wanna try to do the changes in this PR? If not I will try to make the changes next week. |
While trying to get compilation working in my Blazor project I came across another compiler issue. I think for normal frameworks it should by default reference all loaded assemblies. In the current situation, if I try to compile a simple file on .NET Core without specifying the This default wouldn't work for Blazor/WASM projects, for these to work there need to be a possibility to add a Any ideas on this? |
I see, maybe we should split it up to a separate Compiler class than? We could add an additional constructor that require the stream you need but it feels like it would get messy after a while. But I have two different ideas for now:
Or:
Maybe the second option is better but it's just some early ideas. |
fixes issue #42