Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added net7 as target framework #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffward01
Copy link
Collaborator

Hello!

I added net7 as a target framework. It should work fine, let me know if there are any issues with it.

Few questions for you:

1.) I saw this code here: do you also want to add a target of .netstandard2.0?

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|netstandard2.0|AnyCPU'">
    <WarningLevel>3</WarningLevel>
</PropertyGroup>

2.) How do you 'build' this and publish to nuget.org? It would be cool to add 'SourceLink' but im not sure how you publish this. Depending if you use GitHub or Azure Pipelines, the package will be different.


Let me know if there are any issues or questions!

Thanks

@jeffward01
Copy link
Collaborator Author

One more thing I should add:

  • When you target multiple frameworks in CI / CD - you should use dotnet build tools and not nuget build tools
  • Ensure dotnet sdk 7.0.100 or greater is used in the CI / CD pipeline

If you don't use CI / CD - I can set up a Github action that performs this, I just need you to add your nuget API key

Thanks!!

Jeff

@jeffward01
Copy link
Collaborator Author

@MilleBo - I believe that I cannot approve my own PR and need your approval and review for this

@jeffward01
Copy link
Collaborator Author

@MilleBo - bump on this please <3

@MilleBo
Copy link
Contributor

MilleBo commented Dec 7, 2022

Sorry for the later answer. Saw that we had three different pull requests with .NET 7 now. Guess the other two should be remoed and this one should be corrected with correct syntax (net7.0)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants