Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade textual and python #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bluefing
Copy link

  • Upgrading textual to 0.82.0 required minor Python version bump
  • Minimal change required due to namespace_bindings rename to active_bindings in Textual 0.61.0
  • Limited post upgrade testing.
    • Performed manual smoke test by piping tree into tl and reading a python log file

- Upgrading textual to 0.82.0 required minor Python version bump
- Minimal change required due to namespace_bindings rename to active_bindings in Textual 0.61.0
- Limited post upgrade testing.
    - Performed manual smoke test by piping tree into tl and reading a python log file
@bluefing bluefing closed this Oct 27, 2024
@bluefing
Copy link
Author

More testing required - tailing is not working

@bluefing
Copy link
Author

Reopening the PR as tail is working when tl is executed stand alone.
Tail was not working when I had embedded it in another app.

@bluefing bluefing reopened this Oct 27, 2024
@bluefing bluefing marked this pull request as draft October 27, 2024 12:19
@bluefing
Copy link
Author

bluefing commented Oct 27, 2024

Discovered this issue while testing the PR with toolong embedded in another app.
I'll have a look at it to make sure it does not impact stand alone usage.

I suspect it will as

App.check_bindings is now private
https://github.com/Textualize/textual/blob/main/CHANGELOG.md#0690---2024-06-16

image

Replaced the call with a call to simulate_key
@bluefing
Copy link
Author

bluefing commented Oct 27, 2024

tested that the following are working using Python 3.12.7

  • passing multiple log files
    • tabbed
      tl ../logs/app.log ../logs/app.log.2
    • merged
      tl --merge ../logs/app.log ../logs/app.log.2
  • Find
    • Regex and case sensitive search
    • previous and next
  • Go to
  • Line nos
  • Help
  • Mouse (scroll and shift-scroll) and keyboard navigation (g, shift-g, page-up/down, arrow keys)
  • Overlay

@bluefing bluefing marked this pull request as ready for review October 27, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant