Make easy to exclude PCI ids functionality in CMakeLists.txt #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 6, 2024 21:19
…ialized, VC++ compiler warning on val_destructor() because of uninitialized inout param. - In WMI query get Capture, not Name. No need to find & resize string.
|
You could've just updated that one, but sure. Editorialised a bit, applied in 79f0aa5; thanks! |
|
Mucho spasibo Nab, you're a lightning )) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of exclusion of big blob in CMakeLists.txt by
if(INFOWARE_USE_PCIIDS)is that it does lot of fuss with searching git, then clone something, compiling and running some utility.... all what users who do not want PCI IDs functionality even do not want to see.Alternative is to provide small dummy
pci.idsfile and go build with it... but why.