Collection view: table columns definition #1249
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jossmac
requested review from
simonswiss,
BarnabyBishop,
emmatown and
JedWatson
as code owners
🦋 Changeset detectedLatest commit: eb3fed1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emmatown
requested changes
Jul 31, 2024
| @@ -37,29 +37,84 @@ export default config({ | |||
|
|
|||
| ### Columns | |||
|
|
|||
| `columns` — show additional fields in the collection list view. | |||
| By default, only the “slug” of each entry is displayed in the collection table. You can show additional fields by passing a `columns` option. | |||
There was a problem hiding this comment.
By default, only the “slug” of each entry is displayed in the collection table. You can show additional fields by passing a
columnsoption.
This is no longer true with this PR, columns now removes the slug instead of just adding other columns. I don't think we should land this without preserving the ability to show the slug and other fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the columns definition proposal, while maintaining the original API.
Thank you jplhomer for your work in #1110, we appreciate your patience on this feature.
Resolves #1250