Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: github-mode: Hint at different env var names #1356

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Nov 20, 2024

The NEXT_PUBLIC_KEYSTATIC_GITHUB_APP_SLUG is only the right name for Next.JS integrations.
This PR adds a hint for Astro users to look out for a different variable.


Side note: I wonder if this condition should be extended to handle both variables as well 618ba4a#diff-8b4b55d3c75b76109c771dcd8a01e1b1339c07b753bb409b93e71df2f9d4d2cfR91

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 097f21d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

embedCode="<iframe src=\"https://www.youtube.com/embed/BAnfePGzkbg?si=mDDK52Nlhg4v1v9x\" title=\"YouTube video player\" frameborder=\"0\" allow=\"accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share\" allowfullscreen></iframe>" /%}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This change happened automatically when editing via Github UI

@emmatown
Copy link
Member

Side note: I wonder if this condition should be extended to handle both variables as well 618ba4a#diff-8b4b55d3c75b76109c771dcd8a01e1b1339c07b753bb409b93e71df2f9d4d2cfR91

No, this was a specific thing to give users a hint at what might be going wrong because that commit required updates to both @keystatic/core and @keystatic/next but not other framework packages

@emmatown emmatown merged commit cad51fa into Thinkmill:main Nov 20, 2024
5 checks passed
@tordans tordans deleted the patch-4 branch November 21, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants