Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more useful error when reaching /api/keystatic/github/created-app route when the GitHub App is already setup #1364

Merged

Conversation

emmatown
Copy link
Member

Fixes #1357

Note this only fixes the issue described in the title of #1357, the other problem described in the issue where there's a blank page in GitHub App creation flow seems to be something with Astro refreshing after Keystatic writes the env variables which I'm hoping to look into more

…-app` route when the GitHub App is already setup
Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 3c37d55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@keystatic/core Patch
@keystar/docs Patch
@example/astro-content Patch
@example/astro Patch
@example/localization Patch
@example/next-app Patch
@example/next-block-builder Patch
@example/next-pages Patch
@keystatic/remix-test-app Patch
keystatic-docs Patch
@keystatic/templates-astro Patch
@keystatic/templates-nextjs Patch
@keystatic/templates-remix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emmatown emmatown merged commit 46d9c55 into main Nov 28, 2024
8 checks passed
@emmatown emmatown deleted the return-more-useful-error-on-reaching-github-created-app-route branch November 28, 2024 00:25
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/api/keystatic/github/created-app?code=123 returns a 404 Not Found during signup
1 participant