-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add section about disabling indexing #545
docs: add section about disabling indexing #545
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Jed Watson <[email protected]>
Co-authored-by: Simon Vrachliotis <[email protected]>
Co-authored-by: Jed Watson <[email protected]>
Hey @florian-lefebvre ✨ I know I asked you to open this PR in the Astro guide, but I sort of changed my mind on where this information should belong. Last week and the conversations with the Astro docs team led us to a huge re-think of how we should approach guides, particularly framework integration guides. After a major rewrite of this guide with a sharp focus on avoiding any "side quests", I can't help but feel that this section about shutting down I see this info in something like a recipe or a tutorial, for a specific need. It's great content and very useful when you need it, but IMO, it does not belong in the "get setup with Astro" guide itself. I like what the Astro docs do with recipes: If you don't mind, I'll try to stand a "Recipes" section in the nav tomorrow and make your contribution one of these guides. I think it will work better that way. Sorry about the flip-flopping around 😅 I've become very passionate about keeping integration guides as short and to-the-point as possible, and move all tangential content to another place. Let me know what you think! |
Hey! No worries, I also think it makes more sense to get it out of the integration guide. I think recipes are more relevant so that it's not mixed with "official" posts from the team. Regarding the author link, one idea could be to add contributors to recipes like on nuxt v2 section (scroll all the way down on this page). Wdyt? |
Gotta go to bed now, but I've pushed my code in this branch (did not have access to push in your fork): #579 That PR contains all the commit history of this PR here. I also think the recipes is a better place. Right now all docs pages are the same content type in Keystatic, so adding an author would mean every docs page has an author field. I think we can add a Feel free to make suggestions, and let's try to get this merged tomorrow! |
Following #486
cc @simonswiss