Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dependencies #612

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Fix circular dependencies #612

merged 3 commits into from
Aug 31, 2023

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Aug 31, 2023

Fixes #604

This doesn't resolve all the circular dependencies because some would be less practical to remove but this seems to resolve the circular dependencies causing problems (from testing with a snapshot release: @keystatic/[email protected])

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

🦋 Changeset detected

Latest commit: 0e28b61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystatic/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
keystar-ui ✅ Ready (Inspect) Visit Preview Aug 31, 2023 4:47am
keystatic ✅ Ready (Inspect) Visit Preview Aug 31, 2023 4:47am
keystatic-site ✅ Ready (Inspect) Visit Preview Aug 31, 2023 4:47am

@emmatown emmatown marked this pull request as ready for review August 31, 2023 04:51
@emmatown emmatown merged commit dbd09f0 into main Aug 31, 2023
7 checks passed
@emmatown emmatown deleted the fix-circular-deps branch August 31, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependency issue
1 participant