Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset lockfile #619

Merged
merged 4 commits into from
Sep 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stale-ravens-learn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@keystatic/next': patch
---

Remove unnecessary usage of internal `forceOptimisticNavigation` Next.js option
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Box } from '@keystar/ui/layout';
import { action } from '@keystar/ui-storybook';

import { Breadcrumbs, BreadcrumbsProps, Item } from '..';
import { ReactNode } from 'react';

export default {
title: 'Components/Breadcrumbs',
Expand Down Expand Up @@ -82,9 +83,9 @@ function renderBreadcrumbs(children: React.ReactNode) {
);
}

interface Render extends Function {
type Render = (() => ReactNode) & {
storyName?: string;
}
};

function render<T>(props: Partial<BreadcrumbsProps<T>> = {}): Render {
return renderBreadcrumbs(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState } from 'react';
import { ReactNode, useState } from 'react';
import { action, Parameters } from '@keystar/ui-storybook';
import { Grid } from '@keystar/ui/layout';

Expand Down Expand Up @@ -74,9 +74,9 @@ export const CustomWidth = render({
'Error messages inform the user when the input does not meet validation criteria.',
});

interface Render extends Function {
type Render = ((args: Parameters) => ReactNode) & {
storyName?: string;
}
};

function render(props = {}): Render {
return function renderWithArgs(args: Parameters) {
Expand Down
4 changes: 2 additions & 2 deletions packages/next/src/ui/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ export function makePage(config: Config<any, any>) {
href,
params,
push: async path => {
router.push(path, { forceOptimisticNavigation: true });
router.push(path);
},
replace: async path => {
router.replace(path, { forceOptimisticNavigation: true });
router.replace(path);
},
};
}, [href, router, pathname]);
Expand Down
Loading
Loading