Fix astro integration #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4ff81cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
emmatown
force-pushed
the
fix-astro-integration
branch
from
9022773 to
7901df7
Compare
emmatown
force-pushed
the
fix-astro-integration
branch
from
1ec015a to
e70b575
Compare
emmatown
force-pushed
the
fix-astro-integration
branch
from
e70b575 to
736b87d
Compare
emmatown
force-pushed
the
fix-astro-integration
branch
from
736b87d to
8805365
Compare
JedWatson
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates a file into
.astro(since that will already be gitignored) with imports to Keystatic packages and tells Vite to look at it for discovering dependencies to pre-bundle which fixes the problem of getting errors from Vite trying to load CommonJS modules as ESMI'm not going to update the template to use this just yet, I'd like to get this released first to make sure that it definitely works first (though from the snapshot release, it seems to)
Snapshot release for testing:
@keystatic/[email protected], https://github.com/Thinkmill/keystatic/actions/runs/6105022202/job/16567883939#step:7:33Fixes #580