Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Dependency on 'ftp' causes [DEP0005] DeprecationWarning: Buffer() #18

Closed
baerrach opened this issue Sep 20, 2019 · 1 comment · Fixed by #31
Closed

Dependency on 'ftp' causes [DEP0005] DeprecationWarning: Buffer() #18

baerrach opened this issue Sep 20, 2019 · 1 comment · Fixed by #31

Comments

@baerrach
Copy link

See mscdex/node-ftp#255

@samjegal
Copy link

samjegal commented Jan 7, 2020

I've get uri 'https://registry.npmjs.org/get-uri/-/get-uri-2.0.4.tgz'. package.json include in github data-uri-to-buffer: "3", but downloaded file had below version.

  "dependencies": {
    "data-uri-to-buffer": "1",
    "ftp": "~0.3.10",
    "debug": "2",
    "extend": "~3.0.2",
    "file-uri-to-path": "1",
    "readable-stream": "2"
  }

TooTallNate added a commit that referenced this issue Apr 26, 2023
Changes include:

### Major, breaking changes

* _Callback signature has been removed._ Only Promise based interface now.
* _No more default export._ Only named export `getUri()` is available now.
* Minimum Node.js version is now 14.x.
* The `ftp://` protocol has been switched from `ftp` to [`basic-ftp`](https://www.npmjs.com/package/basic-ftp) module.
  * Closes #16
  * Closes #18

### Minor changes

* Proper options typings are now inferred based on the protocol of the URI provided to `getUri()`. For example: `getUri('ftp://...')` will have `FtpOptions` as the second parameter implicitly.
* A `URL` instance can now be provided as the first argument to `getUri()`.

### Misc

* Use pnpm for GH Actions.
* Use Jest for tests.
* Refactor tests to TypeScript.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants