Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-7795 libdiskmgt doesn't always list all disks #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joyent-automation
Copy link

OS-7795 libdiskmgt doesn't always list all disks

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/6846/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@bahamat commented at 2019-08-29T00:18:48

Patch Set 1:

New commits:
commit 67e30b7
try to force clear qnap serial

commit d70a2202e06895503f01e43b8cfef05293f851dd  
OS-7795 qnap tr-004 doesn't present unique serial numbers
@bahamat commented at 2019-08-29T00:38:03

Uploaded patch set 2: Commit message was updated.

@bahamat commented at 2019-08-29T00:38:12

Uploaded patch set 3: Commit message was updated.

@bahamat commented at 2019-08-29T00:38:13

Patch Set 3:

New commits:
commit d965808a58c0ed9803ff255dbb9eae4adc409f4b
3

commit 8ba2431a649d555e6ba2a6dda01687a177a8ba86  
OS-7795 qnap tr-004 doesn't present unique serial numbers
@bahamat commented at 2019-08-29T00:39:00

Uploaded patch set 4: Patch Set 3 was rebased.

@bahamat commented at 2019-08-29T00:39:06

Patch Set 4:

New commits:
commit e61c123bab30db00309711d7d3122790d5cafa86
3

commit b5ded26f61d2f68e9f3b6c3a99b57673b94e373d  
OS-7795 qnap tr-004 doesn't present unique serial numbers
@jjelinek commented at 2019-08-29T12:51:05

Patch Set 4:

(1 comment)

This seems ok, modulo the comment nit.

Patch Set 4 code comments
usr/src/uts/common/io/usb/scsa2usb/scsa2usb.c#1778 @jjelinek

typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants