Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced new developer experience efficiencies #2702

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Commits on Jun 23, 2024

  1. Configuring types.ts tests using a dedicated tsconfig file in each pa…

    …ckage, rather than specifying the arguments on the command line.
    smallsaucepan committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    a924d5e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    180efa7 View commit details
    Browse the repository at this point in the history
  3. Need to remove some old weird type workarounds for the new approach t…

    …o building to work. Simplifies things overall.
    smallsaucepan committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    0821730 View commit details
    Browse the repository at this point in the history
  4. Enabling skipNodeModulesBundle was causing dependent modules to be in…

    …lined in dist/esm/index.js files, greatly increasing their size.
    smallsaucepan committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    232efc7 View commit details
    Browse the repository at this point in the history
  5. These packages weren't actually needed by @turf/turf. Suspect they we…

    …re causing problems in a previous build because skipNodeModulesBundle was true. That's now been removed and @turf/turf does build fine without them.
    smallsaucepan committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    d966fd8 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    5303d1f View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    19780d0 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Configuration menu
    Copy the full SHA
    18710a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Type testing using tsc updated / added for all packages to at least s…

    …ome degree (except @turf/turf). TS projects we statically type check the index.ts itself. JS projects we type check a minimal types.ts file against the index.d.ts definition.
    smallsaucepan committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    70a8580 View commit details
    Browse the repository at this point in the history
  2. Fixed a couple of build errors that seem to be related to how typescr…

    …ipt infers type dependencies of imported types. These must have surfaced due to this PRs new approach to linking package dependencies. Solution was to explicitly define a few return types that previously were being inferred. Should be fixed permanently in typescript 5.5, though nothing really for us to revert. See microsoft/TypeScript#47663 (comment)
    
    Also synced some JSDoc with the function's actual type definition.
    smallsaucepan committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    88ce05a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Refactoring "last-checks" into "bundleCdn" which seems more descripti…

    …ve. Adding empty marchingsquares d.ts to isolines (same as we've done for isobands) to retire a ts-expect-error. Also believe prepublishOnly better target to use than prepublish.
    smallsaucepan committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    cd4b7d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    2fde264 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Simplified MRL config significantly by treating almost all TS and JS …

    …packages the same. Only exception now is @turf/turf.
    
    Run tsc static type checking in all packages (except @turf/turf), even the JS ones. It's a no-op for JS, though standardises our package structure somewhat.
    Added a bunch of standard devDependencies to all projects including typescript, tslib, bench, tape, npm-run-all. Same rationale as above.
    Upgraded to typescript 5.5.4.
    Retired types.ts tests as most of them weren't adding much value any more now that we use tsc --noEmit to type check TS code.
    smallsaucepan committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7997ffe View commit details
    Browse the repository at this point in the history
  2. Decoupled linting of hand written code (prettier, eslint, etc) from l…

    …inting of generated code (escheck). We now run the former during top level test, and the latter only during pre-publish after we've run a top level build.
    
    Upgraded the eslint plugin to match new typescript version, fixed a couple of minor "new" lint errors.
    smallsaucepan committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8a3974e View commit details
    Browse the repository at this point in the history