Mfa branch #84
Merged
Mfa branch #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefpiatek
reviewed
Jun 27, 2024
src/rred_reports/reports/auth.py
Outdated
Comment on lines
20
to
22
| LOG_FORMAT = "%(levelname)-10s %(asctime)s %(name)-30s %(funcName)-35s %(lineno)-5d: %(message)s" | ||
| logging.basicConfig(level=logging.INFO, format=LOG_FORMAT) | ||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
I think we're using loguru in this project, can just replace all of this with
from loguru import logger
src/rred_reports/reports/auth.py
Outdated
Comment on lines
52
to
53
| f"Please follow auth flow by going to this link, then enter in the final redirect URL {auth_code_flow['auth_uri']}\n" | ||
| ) |
There was a problem hiding this comment.
should probably change the text here to say to write to the access_link.txt file in at the top level of the directory
src/rred_reports/reports/auth.py
Outdated
| else: | ||
| logger.info("No suitable token exists in cache. Let's initiate interactive login.") | ||
| auth_code_flow = app.initiate_auth_code_flow(scopes=[self.settings.scope], login_hint=self.settings.username) | ||
| final_url = click.confirm( |
There was a problem hiding this comment.
because we don't use it, probably worth not keeping the output
Suggested change
| final_url = click.confirm( | |
| click.confirm( |
src/rred_reports/reports/auth.py
Outdated
| result = app.acquire_token_silent([self.settings.scope], account=accounts[0]) | ||
| else: | ||
| logger.info("No suitable token exists in cache. Let's initiate interactive login.") | ||
| auth_code_flow = app.initiate_auth_code_flow(scopes=[self.settings.scope], login_hint=self.settings.username) |
There was a problem hiding this comment.
Looks like you can set how long this token is valid for, might be worth seeing if we can make it a day so that you don't have to do it every hour
Suggested change
| auth_code_flow = app.initiate_auth_code_flow(scopes=[self.settings.scope], login_hint=self.settings.username) | |
| auth_code_flow = app.initiate_auth_code_flow(scopes=[self.settings.scope], login_hint=self.settings.username, max_age=60*60*24) |
|
looks like you'll need to resolve some conflicts before it can merge btw, have you done that before? |
stefpiatek
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for MFA