CSL-24: Company Registration Certificate upload #25
Conversation
Added form-data module
jamiecarterHO
requested review from
dk4g,
RobertMcCann and
vinodhasamiyappanHO
|
Ready for first review. Some discussion to be had about where reusable methods/behaviours should be stored. I believe they can be shared cross-forms as they are but happy to entertain any alternative ideas @dk4g |
| @@ -55,9 +55,11 @@ module.exports = { | |||
| }, | |||
| keycloak: { | |||
| token: process.env.KEYCLOAK_TOKEN_URL, | |||
There was a problem hiding this comment.
I think it is worth renaming this property to something like tokenUrl, otherwise it gives the impression that the token already exists.
| async auth() { | ||
| const requiredProperties = ['clientId', 'secret', 'username', 'password']; | ||
|
|
||
| if (!config.keycloak.token) { |
There was a problem hiding this comment.
tokenUrl See comment about property naming in config.js
| * Assuming config.dateLocales is 'en-GB' and config.dateFormat is { day: '2-digit', month: '2-digit', year: 'numeric' } | ||
| * formatDate('2023-10-01'); // returns '01 10 2023' |
There was a problem hiding this comment.
example can be updated to be more relevant to existing configuration data
| * | ||
| * @example | ||
| * sanitiseFilename('filename.txt'); | ||
| * // returns 'fi**REDACTED**le.txt' |
There was a problem hiding this comment.
le.txt-> me.txt
* // returns 'fi**REDACTED**me.txt'
| "add-another-substance": "Add another substance" | ||
| } | ||
| "add-another-substance": "Add another substance", | ||
| "delete": "Remove" |
There was a problem hiding this comment.
I noticed there is a remove translation on line 14, which probably can be reused? but will require updates on template and js event handlers
What?
CSL-24 Adds the configuration and files required to display the "Upload company registration certificate" page and enable uploads via file-vault to S3.
Why?
The updates will allow deployment of a file-vault container in the namespace that can connect to the S3 bucket, and add the page and functionality for uploads
Check list