Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSL - 29 - PCA - Added declaration and application submitted page #26

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vinodhasamiyappanHO
Copy link
Contributor

What?

  • CSL-29 - PCA - Declaration & Precursor Chemicals Application submitted pages

Why?

  • Creating new pages for precursor chemicals new applications. Added Declaration & Precursor Chemicals Application submitted pages

How?

  • Added necessary step configuration and field specific variables.
  • Added required field validation for all pages

Testing?

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

Copy link
Collaborator

@dk4g dk4g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just a minor change on removing reddened attribute

{{<partials-page}}
{{$page-content}}
{{#renderField}}declaration-check{{/renderField}}
<div id="loader-container" class=""></div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class="" can be removed

@@ -207,3 +207,12 @@ pre.looped-records {
margin: 20px 15px 20px 20px;
padding: 10px 0 10px 30px;
}

.spinner-loader {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing parts:

.spinner-container {
    display: none;
    margin-top: 20px;
    align-items: center;
}

.spinner-message {
    margin-left: 10px;
}

@-webkit-keyframes spin {
    0% { -webkit-transform: rotate(0deg); }
    100% { -webkit-transform: rotate(360deg); }
}

@keyframes spin {
    0% { transform: rotate(0deg); }
    100% { transform: rotate(360deg); }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants