EPP-52 Setting up dev environment #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-gu-hof
approved these changes
Dec 3, 2024
| const env = process.env.NODE_ENV || 'production'; | ||
|
|
||
| module.exports = { | ||
| PRETTY_DATE_FORMAT: 'Do MMMM YYYY', |
There was a problem hiding this comment.
Not sure if 'Do' is correct, could you check, I'll update the skeleton repo as well if that is wrong
| "accessible-autocomplete": "^2.0.4", | ||
| "bl": "^6.0.12", | ||
| "busboy": "^1.6.0", | ||
| "hof": "^20.5.6", |
PaolaDMadd-Pro
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Good work, I added small suggestions, that won't preclude the merging.
@william-gu-hof
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "header": "HOF epp", | |||
There was a problem hiding this comment.
According to figma the correct header for this page is "Explosive precursors and poisons licensing"
There was a problem hiding this comment.
do we need a template for the caseworker email?
| @@ -0,0 +1,48 @@ | |||
| { | |||
| "name": "hof-epp-form", | |||
There was a problem hiding this comment.
Please verify if the name of the app needs to reflect the name of the git repository or hosting platform name
| { | ||
| "name": "hof-epp-form", | ||
| "version": "1.0.0", | ||
| "description": "Simple standard form made using HOF", |
There was a problem hiding this comment.
Suggested change
| "description": "Simple standard form made using HOF", | |
| "description": "Explosive precursors and poisons", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
EPP-52 - Create dev environment
Why?
How?
Testing?
Tested on local machine
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit