You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Then changing IReadingOrderDector interface and implementing classes to use IBoundingBox as it's parameter
Adding an overload that takes a Func<T, PdfRectangle> would allow the caller to specify any bounding box making the interface more useful.
Breaking changes: The IReadingOrderDector will instead return an IReadOnlyList<T> which will be the ordered results. This would mean TextBlock.ReadingOrder is not set which is a breaking change. But some code can be added that if type T is TextBlock then ReadingOrder is set
Happy to make the changes
The text was updated successfully, but these errors were encountered:
I think the Letter class has a method instead of a property to get the bounding box. Might be a good opportunity to change that too (in my mind, the letters, text lines and text block should implement your interface, but please let me know what you think)
Currently the interface
IReadingOrderDetector
relies onTextBlock
as a parameter. This limits it's use to theTextBlock
class.I propose adding an
IBoundingBox
interfaceThen changing
IReadingOrderDector
interface and implementing classes to useIBoundingBox
as it's parameterAdding an overload that takes a
Func<T, PdfRectangle>
would allow the caller to specify any bounding box making the interface more useful.Breaking changes: The
IReadingOrderDector
will instead return anIReadOnlyList<T>
which will be the ordered results. This would meanTextBlock.ReadingOrder
is not set which is a breaking change. But some code can be added that if type T isTextBlock
thenReadingOrder
is setHappy to make the changes
The text was updated successfully, but these errors were encountered: