Allow Reading Orders to support any class that has a bounding box and introduce line Segmenter #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2024 17:31
… box/PdfRectangle - Introduce IBoundingBox interface
and refactoring
|
@davebrokit I'll review that tomorrow - thx for the PR! |
|
@davebrokit thanks a lot for the work and for taking the time to add tests. I'm afraid I cannot review the PR as is, because it covers too many areas of the code and different aspects of the logic. Do you mind splitting it in different PRs by "topic"? I'd recommend starting with the Please don't take my feedback as a judgment of your changes - it's not. It is really about being able to confidently review your changes and merge them asap. |
|
Will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#844 and #855