Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for bugs found during approximations testing #217

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

IgorFilimonov
Copy link

Fixes bugs such as:

  1. Incorrect size of a list after addAll()
  2. Inability of maps to hold nulls as keys (for example, appropriate map.put(null, null) used to throw "nullRef on top")
  3. Object cloning
  4. Now test for ArrayList decoder should be passed

import org.usvm.UHeapRef
import org.usvm.USort
import org.usvm.UState
import org.usvm.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, avoid such changes

@@ -89,6 +77,12 @@ class JcMethodApproximationResolver(
private val usvmApiSymbolicMap by lazy { ctx.cp.findClassOrNull<SymbolicMap<*, *>>() }
private val usvmApiSymbolicIdentityMap by lazy { ctx.cp.findClassOrNull<SymbolicIdentityMap<*, *>>() }

@Suppress("RecursivePropertyAccessor")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be an Intellij warning, not a Kotlin compiler warning. Please, don't suppress such warnings.

@Saloed
Copy link
Collaborator

Saloed commented Oct 18, 2024

ApproximationsDecoderTest > testArrayListDecoder() FAILED
    java.lang.NullPointerException at ApproximationsDecoderTest.kt:760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants