FIX: WIP Set macOS Xbox gamepad based on PID/VID #2097
Draft
+180
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An attempt to fix https://jira.unity3d.com/browse/ISXB-1264 in case @ieuanrees validates that this button mapping works.
Only for macOS since Windows uses XInput.
So far it only does this for a particular PID VID group and can likely be expanded and improved.
Ideally we could probably expand the coverage by using this database and define the layouts accordingly for Xbox controllers.
Testing status & QA
Overall Product Risks
Unclear what other combinations of PID/VID we are missing.
Comments to reviewers
In general, I don't like this approach since I'm creating a lot of duplication.
But if this solves the original bug while introducing regressions, I'm open to discuss a better approach with the team (after holidays)
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: