chore: update to supported go versions #157
Open
+37
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
reviewed
Nov 30, 2023
| github.com/twmb/murmur3 v1.1.5/go.mod h1:Qq/R7NUyOfr65zD+6Q5IHKsJLwP7exErjN6lyyq3OSQ= | ||
| gopkg.in/h2non/gock.v1 v1.0.10 h1:D4j796HhgidcxF0LnDyFXcoEbEZWoLEWf0kRh61p22w= | ||
| gopkg.in/h2non/gock.v1 v1.0.10/go.mod h1:KHI4Z1sxDW6P4N3DfTWSEza07YpkQP7KJBfglRMEjKY= | ||
| github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= |
There was a problem hiding this comment.
why do we have explosion of versions here?
There was a problem hiding this comment.
I believe that go 1.17 updated the format for go.mod/go.sum, and since we now explicitly state go 1.19 in our go.mod, the new format takes effect.
|
With this change we might be dropping support for older versions of go. Maybe something we want to do... I did test the current v4 against newer versions of go and it seems to work well: #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Having read https://go.dev/doc/devel/release I realised we haven't looked at our build matrix since 1.16 came out, and our go.mod is still pointing to 1.13 which was EoL 2021-02-16.
This PR bumps go.mod to 1.19 (the current oldest supported version) and updates the build matrix to 1.19, 1.20 and 1.21