Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ruby musl binaries in gem build #161

Merged
merged 13 commits into from
Nov 4, 2024
Merged

Conversation

sighphyre
Copy link
Member

@sighphyre sighphyre commented Nov 4, 2024

Number of small fixes to the build:

  • Consumes the binary outputs from chore: publish musl binaries with correct names #160, related fixes to the way we're now loading the binaries in the Ruby code
  • Moves the publish task to a one shot at the end of the build (timing meant this could sometimes fail for some gems)
  • Removes the lock file, this is a library, the parent can resolve the gems. Importantly, this means we don't have to specify the platform we're building for, it'll be the platform the final program gets built for, which is important for musl builds

@sighphyre sighphyre marked this pull request as ready for review November 4, 2024 13:41
@sighphyre sighphyre merged commit dd5f287 into main Nov 4, 2024
2 checks passed
@sighphyre sighphyre deleted the fix/ruby-musl-binaries branch November 4, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants